Manual input identification for SSRF #1290
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcuri82
requested changes
Aug 26, 2025
core/src/main/kotlin/org/evomaster/core/problem/security/service/SSRFAnalyser.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/evomaster/core/problem/security/service/SSRFAnalyser.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/evomaster/core/problem/security/service/SSRFAnalyser.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/evomaster/core/problem/security/service/SSRFAnalyser.kt
Outdated
Show resolved
Hide resolved
seran
commented
Aug 29, 2025
| httpCallbackVerifier.isCallbackURL(gene.getValueAsRawString()) | ||
| } | ||
|
|
||
| if (hasCallBackURL) { | ||
| // FIXME: When the code reaches this point during SSRF phase |
There was a problem hiding this comment.
Hi @arcuri82,
I can see the code reach the AbstractRestFitness during the SSRF detection phase. However, WireMock seems to be null at this point although it was initiated earlier. I'm not sure why this is happening, need your assistance to debug this further.
seran
commented
Aug 29, 2025
| @@ -75,7 +80,9 @@ class HttpCallbackVerifier { | |||
| * Method generates a unique callback link to be used as payload for SSRF. | |||
| */ | |||
| fun generateCallbackLink(name: String): String { | |||
| val ssrfPath = "/sink/${counter++}" | |||
| // FIXME: sink/EM_0 <- slash get replaced with a comma at some point, which fails | |||
There was a problem hiding this comment.
This was a problem too, for some reason slash after sink get replaced with a comma when recomputing the fitness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.